Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

should add role="presentation" on the surrounding li #158

Open
gaurav5430 opened this issue May 19, 2022 · 0 comments
Open

should add role="presentation" on the surrounding li #158

gaurav5430 opened this issue May 19, 2022 · 0 comments

Comments

@gaurav5430
Copy link

In the example usage on the website and the example as part of the repo, the li which contains the menuitem does not have its semantics hidden (using role=presnetation or role=none). Which means for a screenreader user this is extra info which doesn't make sense semantically ?

Would it be better to add role="presentation" on these wrapper lis

This is also suggested on the WAI ARIA pattern

amal-qb added a commit to qburst/react-aria-menubutton that referenced this issue Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant