-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1487] Fix CAM for Windows, add gitattributes and add Windows CI #1512
Conversation
For the github actions workaround see: actions/runner-images#712 |
What are you doing? Please stop ... it's already dead. |
Debugging Github Actions. What else? |
There seems to be some problem with Hadoops file creation on the Windows VM. It works locally. I will test this with the new version, when #1519 is merged. |
This looks like a lot of fun! |
I forgot about winutils. It was already installed on my machine, so it worked there. |
The MiniAccumuloCluster seems to fail too, so excluded both Accumulo and HBase. |
My test doesn't pass ... ignore it. |
The tests are fine^^ Only the test cluster is... not good. |
Finally success. |
For now i excluded accumulo again. You can review/merge now, @galpha. I included 2 options to the maven builds to make the log more usable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - just a minor move of a comment in the readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Use
\n
as line ending in CAM (CanonicalAdjacencyMatrixBuilder
). Since the result string isn't meant to be written to files, it is better to keep it the same for all OS's.Add
.gitattributes
with options to always checkout text files with LF line endings (regardless of git config). This is needed for the CAM tests in gradoop-flink and gradoop-temporal and for checkstyle (all source code has to be LF).This restores most tests for Windows builts. Only HBase tests still fail, because to create the HBase mini-cluster on Windows a cygwin environment is necessary (See point 4 of this old HBase doc).
Related Issue
Fixes #1487
Builds on windows work, if HBase tests are skipped. For example by either skipping all tests or by excluding gradoop-hbase.
Edit: I updated the github actions to include Windows and the Readme build instructions to skip tests for Windows.
Motivation and Context
Windows builds
How Has This Been Tested?
I built it on a Windows machine. Tests fail when reaching HBase tests and the build succeeds when skipping tests.
Types of Changes
Checklist: