-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Adapter error when FIPS mode is enabled #602
Comments
@chrischin478 could you try to propose a fix based on your finding? |
@nicor88 I've included the proposal in the description. Let me know what you think. |
I've see it, I think is fine to try out what you suggested - that's why I wrote to try to propose a PR, because we can actually verify via functional tests that all works fine. Looking at dbt-core code seems that the use from dbt.utils import md5
@property
def unique_field(self) -> str:
return f"athena-{md5(self.s3_staging_dir)}" it's totally fine for me. |
Great! I'll get a PR started.
…On Thu, Mar 14, 2024, 6:31 PM nicor88 ***@***.***> wrote:
I've see it, I think is fine to try out what you suggested.
Looking at dbt-core code seems that the use md5(self.project_name), but
what you suggested:
from dbt.utils import md5
@propertydef unique_field(self) -> str:
return f"athena-{md5(self.s3_staging_dir)}"
it's totally fine for me.
—
Reply to this email directly, view it on GitHub
<#602 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALIDJQXBQOFPRZFDJKS6WLDYYIQKZAVCNFSM6AAAAABEWORNZOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJYGU4DQNZXGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Is this a new bug in dbt-athena?
Current Behavior
The Athena adapter is failing for the following error when FIPS is enabled, for example on RHEL>=8.6:
ValueError: [digital envelope routines: EVP_DigestInit_ex] disabled for FIPS
dbt-core had a recent bug dbt-labs/dbt-core#6900 addressing this that was resolved. I think the fix for this would be changing this:
https://github.com/dbt-athena/dbt-athena/blob/40855b36249c9b890bab3c6d77afe88555ad6a85/dbt/adapters/athena/connections.py#L73-L75
To use dbt utils md5:
Expected Behavior
dbt-athena
runs without FIPS errorSteps To Reproduce
No response
Environment
Additional Context
No response
The text was updated successfully, but these errors were encountered: