Convert incremental on_schema_change tests #469

jtcohen6 · 2023-01-14T14:43:30Z

The copy-pasted tests have been updated twice since fall 2021, in ways that diverged from the same tests in dbt-core:

Rework _dbt_max_partition #41 — although this failed to actually add the test case it meant to! added here
Support for ingestion time partition table on BigQuery as incremental materialization #136 — although this test is not actually related to on_schema_change functionality

I have read the contributing guide and understand what's expected of me
I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
~~I have run changie new to create a changelog entry~~

dev-requirements.txt

ChenyuLInx

LGTM, seems ready to merge after core PR and removal of already marked todo item in this PR

jtcohen6 added the Skip Changelog Skips GHA to check for changelog file label Jan 14, 2023

cla-bot bot added the cla:yes label Jan 14, 2023

jtcohen6 commented Jan 14, 2023

View reviewed changes

dev-requirements.txt Outdated Show resolved Hide resolved

jtcohen6 mentioned this pull request Jan 14, 2023

mv on_schema_change tests -> "adapter zone" dbt-labs/dbt-core#6618

Merged

5 tasks

ChenyuLInx approved these changes Jan 18, 2023

View reviewed changes

jtcohen6 added 2 commits January 19, 2023 13:20

Convert incremental on_schema_change tests

de882a7

Switch to dbt-core main

75cfb88

jtcohen6 force-pushed the jerco/convert-onschemachange-tests branch from dcd01cc to 75cfb88 Compare January 19, 2023 12:20

jtcohen6 merged commit 1d6b428 into main Jan 19, 2023

jtcohen6 deleted the jerco/convert-onschemachange-tests branch January 19, 2023 12:48

Provide feedback