Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate_model_yaml with upstream_descriptions: true should also read descriptions from upstream sources. #153

Closed
esegal opened this issue Dec 18, 2023 · 0 comments · Fixed by #154
Closed

generate_model_yaml with upstream_descriptions: true should also read descriptions from upstream sources. #153

esegal opened this issue Dec 18, 2023 · 0 comments · Fixed by #154
Labels
enhancement New feature or request triage

Comments

@esegal
Copy link
Contributor

esegal commented Dec 18, 2023 •
edited
Loading

Describe the feature

When running generate_model_yaml with upstream_descriptions: true - I expect descriptions would also be read from source nodes, rather than only models.

Describe alternatives you've considered

Additional context

Who will this benefit?

I believe everyone who uses upstream_descriptions and have documented sources will benefit.

Are you interested in contributing this feature?

Yes: #154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Read upstream descriptions from sources esegal/dbt-codegen
1 participant
@esegal