Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read upstream descriptions from sources #154

Merged
merged 5 commits into from
Feb 28, 2024
Merged

Read upstream descriptions from sources #154

merged 5 commits into from
Feb 28, 2024

Conversation

esegal
Copy link
Contributor

@esegal esegal commented Dec 18, 2023 •
edited
Loading

resolves #153

This is a:

  • bug fix with no breaking changes

All pull requests from community contributors should target the main branch (default).

Description & motivation

generate_model_yaml now reads upstream description from sources, as well as models.

Checklist

  • This code is associated with an issue which has been triaged and accepted for development.
  • I have verified that these changes work locally
  • I have updated the README.md (if applicable)
  • I have added tests & descriptions to my models (and macros if applicable)
  • I have added an entry to CHANGELOG.md

@esegal esegal marked this pull request as ready for review December 18, 2023 10:38
@esegal esegal mentioned this pull request Dec 18, 2023
Closed
9 tasks
@esegal esegal changed the title Feature/read upstream descriptions from source Read upstream descriptions from sources Dec 18, 2023
@esegal esegal mentioned this pull request Dec 18, 2023
Closed
@gwenwindflower gwenwindflower self-assigned this Feb 28, 2024
gwenwindflower
gwenwindflower approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@gwenwindflower gwenwindflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Very well done, excellent improvement to this functionality, and great job with testing it.

@gwenwindflower gwenwindflower merged commit 53d787b into dbt-labs:main Feb 28, 2024
1 check passed
@gwenwindflower
Copy link
Contributor

Also thank you for patience, truly appreciated @esegal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gwenwindflower gwenwindflower gwenwindflower approved these changes

Assignees

@gwenwindflower gwenwindflower

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

generate_model_yaml with upstream_descriptions: true should also read descriptions from upstream sources.
2 participants
@esegal @gwenwindflower