Escape upstream descriptions in generate_model_yaml #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gwenwindflower
approved these changes
Feb 28, 2024
|
Had to add some unrelated commits to get the test suite working, nothing to do with your code, it was broken before. LGTM now though and all tests are passing, merging in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #142
This is a:
All pull requests from community contributors should target the
mainbranch (default).Description & motivation
JSON-escapes upstream descriptions before inserting them in the YAML in
generate_model_yaml.Checklist
I have updated the README.md (if applicable)