Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-66] [Bug] dbt starter project's seed folder is still called data #4588

Closed
1 task done
joellabes opened this issue Jan 19, 2022 · 2 comments · Fixed by #4589
Closed
1 task done

[CT-66] [Bug] dbt starter project's seed folder is still called data #4588

joellabes opened this issue Jan 19, 2022 · 2 comments · Fixed by #4589
Labels
bug Something isn't working init Issues related to initializing the dbt starter project jira
Milestone
v1.0.2

Comments

@joellabes
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The starter project directory still has data as a folder, but the dbt_project.yml has changed it to seeds:

dbt-core/core/dbt/include/starter_project/dbt_project.yml

Line 18 in 11436fe

seed-paths: ["seeds"]

image

Expected Behavior

The folder to be called seeds.

Steps To Reproduce

Run dbt init and follow the default interactive path
Add a seed, and a model that refs it
Run dbt build

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

What database are you using dbt with?

No response

Additional Context

No response
@joellabes joellabes added bug Something isn't working triage labels Jan 19, 2022
@joellabes joellabes mentioned this issue Jan 19, 2022
Merged
4 tasks
@jtcohen6 jtcohen6 added this to the v1.0.2 milestone Jan 19, 2022
@jtcohen6 jtcohen6 added the init Issues related to initializing the dbt starter project label Jan 19, 2022
@leahwicz leahwicz added the jira label Jan 19, 2022
@leahwicz leahwicz changed the title [Bug] dbt starter project's seed folder is still called data [CT-66] [Bug] dbt starter project's seed folder is still called data Jan 19, 2022
@emmyoop emmyoop assigned emmyoop and unassigned emmyoop Jan 19, 2022
@emmyoop
Copy link
Member

emmyoop commented Jan 19, 2022

Great catch @joellabes!

@emmyoop emmyoop removed the triage label Jan 19, 2022
@leahwicz
Copy link
Contributor

leahwicz commented Feb 1, 2022

BAckport: #4592

patped added a commit to patped/dbt-oracle that referenced this issue Mar 17, 2022
@patped
Migrate seed in test project to new folder structure
15baa6b 
Ref.
1: dbt-labs/dbt-core#4588
patped added a commit to patped/dbt-oracle that referenced this issue Mar 18, 2022
@patped
Migrate seed in test project to new folder structure
9bf8348 
Ref.
1: dbt-labs/dbt-core#4588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working init Issues related to initializing the dbt starter project jira
Projects
None yet
Milestone
v1.0.2
Development

Successfully merging a pull request may close this issue.

Rename data directory to seeds dbt-labs/dbt-core
4 participants
@emmyoop @joellabes @jtcohen6 @leahwicz