Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dbt common 1.6 #10489

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Bump dbt common 1.6 #10489

merged 2 commits into from
Jul 26, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jul 26, 2024

Resolves #8062

Problem

#10414 requires dbt-common 1.6 contracts, so we should bump the min dbt-common version for dbt-core

Solution

update setup.py

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Jul 26, 2024
@MichelleArk MichelleArk marked this pull request as ready for review July 26, 2024 14:44
@MichelleArk MichelleArk requested a review from a team as a code owner July 26, 2024 14:44
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.83%. Comparing base (cab6dab) to head (111d6d3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10489      +/-   ##
==========================================
- Coverage   88.86%   88.83%   -0.03%     
==========================================
  Files         180      180              
  Lines       22643    22643              
==========================================
- Hits        20121    20115       -6     
- Misses       2522     2528       +6     
Flag Coverage Δ
integration 86.06% <ø> (-0.16%) ⬇️
unit 62.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.22% <ø> (ø)
Integration Tests 86.06% <ø> (-0.16%) ⬇️

@MichelleArk MichelleArk changed the title Bump dbt common 1 6 Bump dbt common 1.6 Jul 26, 2024
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MichelleArk MichelleArk merged commit c598741 into main Jul 26, 2024
73 of 74 checks passed
@MichelleArk MichelleArk deleted the bump-dbt-common-1-6 branch July 26, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2809] Support ref in foreign key constraint expressions
2 participants