Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try skipping _add_config_call entirely #10705

Closed
wants to merge 1 commit into from
Closed

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Sep 12, 2024

Just for testing.

@gshank gshank requested a review from a team as a code owner September 12, 2024 16:21
@cla-bot cla-bot bot added the cla:yes label Sep 12, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.70%. Comparing base (ab500a9) to head (abbef75).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10705      +/-   ##
==========================================
- Coverage   88.90%   85.70%   -3.20%     
==========================================
  Files         180      180              
  Lines       22785    22785              
==========================================
- Hits        20257    19529     -728     
- Misses       2528     3256     +728     
Flag Coverage Δ
integration 82.19% <100.00%> (-3.94%) ⬇️
unit 62.36% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.36% <100.00%> (ø)
Integration Tests 82.19% <100.00%> (-3.94%) ⬇️

@gshank gshank closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant