Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track batch execution time for microbatch models #10828

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

QMalcolm
Copy link
Contributor

@QMalcolm QMalcolm commented Oct 4, 2024

Resolves #10825

Problem

We weren't tracking the execution time of batches for microbatch models. Thus, we were always logging that they took no time to run (0.00 seconds) which didn't actually match reality.

Solution

Begin tracking the time it takes for a batch to run, and propagate that information to the batch run result.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Oct 4, 2024
@QMalcolm QMalcolm marked this pull request as ready for review October 4, 2024 21:41
@QMalcolm QMalcolm requested a review from a team as a code owner October 4, 2024 21:41
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.17%. Comparing base (6b9c1da) to head (1e2e23a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10828      +/-   ##
==========================================
- Coverage   89.19%   89.17%   -0.02%     
==========================================
  Files         183      183              
  Lines       23402    23404       +2     
==========================================
- Hits        20873    20871       -2     
- Misses       2529     2533       +4     
Flag Coverage Δ
integration 86.47% <100.00%> (-0.03%) ⬇️
unit 62.11% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.11% <50.00%> (-0.01%) ⬇️
Integration Tests 86.47% <100.00%> (-0.03%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] timing for individual batches in logs
1 participant