[#2990] Normalize global CLI args/flags #3839
Conversation
|
Removed: strict, use_cache, test_new_parser. Added command line argument before subcommands: --no-version-check, --fail-fast, --profiles_dir. Global CLI flags: use_experimental_parser, debug, log_format, write_json, partial_parse, use_colors, send_anonymous_user_stats, no_version_checks, fail_fast, profiles_dir, printer_width. All environment variables start with DBT_, like DBT_PROFILES_DIR. |
| FAIL_FAST = get_flag_value('FAIL_FAST', args, user_config) | ||
| SEND_ANONYMOUS_USAGE_STATS = get_flag_value('SEND_ANONYMOUS_USAGE_STATS', args, user_config) | ||
| PRINTER_WIDTH = get_flag_value('PRINTER_WIDTH', args, user_config) | ||
|
|
There was a problem hiding this comment.
Love how organized + centralized these all are now
gshank
force-pushed
the
2990_global_cli_flags
branch
2 times, most recently
from
2956b6a
to
f48faa0
Compare
gshank
force-pushed
the
2990_global_cli_flags
branch
2 times, most recently
from
36350bb
to
1339ef6
Compare
|
I've merged the flags with the 'args' that show up in run_results.json. I removed the 'profiles_dir' attribute from UserConfig. Switched to using flags.VERSION_CHECK instead of args. etc etc. Going to review the flags to make sure they're all actually being used and that there are tests, but hopefully functionality is done. |
gshank
force-pushed
the
2990_global_cli_flags
branch
4 times, most recently
from
999bf10
to
99a3b99
Compare
gshank
force-pushed
the
2990_global_cli_flags
branch
from
e1db970
to
cde2f87
Compare
gshank
force-pushed
the
2990_global_cli_flags
branch
from
cde2f87
to
779c789
Compare
resolves #2990
Description
Make global CLI arguments/flags consistent by allowing them to be set 1) as a command line argument (before subcommands), 2) as an environment variable 3) in the config part of the profile.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.