removed deprication for materialization-return and replaced it with a… #3893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshank
approved these changes
Sep 16, 2021
jtcohen6
reviewed
Sep 17, 2021
Comment on lines
114
to
115
| self.run_dbt(['run'], expect_pass=False) | ||
|
|
There was a problem hiding this comment.
If you want, you can check the results for the explicit error message you're expecting:
results = self.run_dbt(['run'], expect_pass=False)
assert 'did not explicitly return a list of relations' in results[0].messageI wouldn't say that's required here, though it could be a nice way to ensure we're providing users with a helpful error message, and not just failing silently.
emmyoop
force-pushed
the
2798_enact_deprecations
branch
from
382c52a
to
237048c
Compare
…/dbt into 2798_enact_deprecations # Conflicts: # test/integration/012_deprecation_tests/test_deprecations.py
jtcohen6
reviewed
Sep 22, 2021
| @@ -1,3 +1,13 @@ | |||
| ## dbt 1.0.0 (Release TBD) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3896
Description
Enact deprecation for
materialization-return. Removed the deprecation warning and replaced it with an exception.Looking for feedback to see if there's anything I'm overlooking (other than updating the CHANGELOG.md). I tested locally and ran all tests.
Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.