Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust logic when finding approx matches for model or test matching #4076

Merged
merged 6 commits into from
Nov 29, 2021
Merged

Adjust logic when finding approx matches for model or test matching #4076

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6f9cff2
adjust logic when finding approx matches
emilieschario Oct 15, 2021
5e16c54
update changelog
emilieschario Nov 24, 2021
aa7579b
Merge branch 'main' into main
emilieschario Nov 24, 2021
c0a96a3
Update core/dbt/adapters/base/relation.py
emilieschario Nov 29, 2021
59e5b26
Merge branch 'main' into main
emilieschario Nov 29, 2021
4ce06e7
Update changelog
jtcohen6 Nov 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

### Under the hood
- Change some CompilationExceptions to ParsingExceptions ([#4254](http://github.com/dbt-labs/dbt-core/issues/4254), [#4328](https://github.com/dbt-core/pull/4328))

- Adjust logic when finding approximate matches for models and tests ([#4076](https://github.com/dbt-labs/dbt-core/pull/4076))

## dbt-core 1.0.0rc2 (November 22, 2021)

Expand Down Expand Up @@ -110,6 +110,7 @@ Contributors:
- Schedule partial parsing for schema files with env_var changes ([#3885](https://github.com/dbt-labs/dbt-core/issues/3885), [#4162](https://github.com/dbt-labs/dbt-core/pull/4162))
- Skip partial parsing when env_vars change in dbt_project or profile ([#3885](https://github.com/dbt-labs/dbt-core/issues/3885), [#4212](https://github.com/dbt-labs/dbt-core/pull/4212))


Contributors:
- [@sungchun12](https://github.com/sungchun12) ([#4017](https://github.com/dbt-labs/dbt/pull/4017))
- [@matt-winkler](https://github.com/matt-winkler) ([#4017](https://github.com/dbt-labs/dbt/pull/4017))
Expand Down
5 changes: 4 additions & 1 deletion core/dbt/adapters/base/relation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,10 @@ def matches(
if not self._is_exactish_match(k, v):
exact_match = False

if self.path.get_lowered_part(k) != v.lower():
if (
self.path.get_lowered_part(k).strip(self.quote_character) !=
emilieschario marked this conversation as resolved.
Show resolved Hide resolved
v.lower().strip(self.quote_character)
):
approximate_match = False

if approximate_match and not exact_match:
Expand Down