Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping artifact versions for v1 #4191

Merged
merged 4 commits into from
Nov 4, 2021
Merged

Bumping artifact versions for v1 #4191

merged 4 commits into from
Nov 4, 2021

Conversation

leahwicz
Copy link
Contributor

@leahwicz leahwicz commented Nov 2, 2021

Description

Before releasing the v1.0.0RC1, we need to bump our schema versions for changes that were made

Related PR for schema bump: dbt-labs/schemas.getdbt.com#6

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

CHANGELOG.md Outdated
### Fixes
- Changes unit tests using `assertRaisesRegexp` to `assertRaisesRegex`

### Under the hood
Bump artifact schema versions for 1.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we include a brief overview of what structurally changed in manifest, run-results, + sources? For easy reference by users, and by me when I go to update docs.getdbt.com

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry you asked for a brief description and not just what version was bumped...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah! I have a sense it's very small things that changed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more changes than would make sense to write down but I listed the big ones. The small ones are some places we changed int to float but I listed renames and bigger things like that

@jtcohen6 jtcohen6 merged commit 95d087b into main Nov 4, 2021
@jtcohen6 jtcohen6 deleted the leahwicz/checkDiff branch November 4, 2021 10:19
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* Bumping artifact versions for v1

* Adding schema in Changelog

* Update CHANGELOG.md

* Update changelog entry

Co-authored-by: Jeremy Cohen <jeremy@dbtlabs.com>

automatic commit by git-black, original commits:
  95d087b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants