Avoid errors when missing column in yaml doc #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadero
changed the title
kadero
changed the title
jtcohen6
approved these changes
Nov 16, 2021
| @@ -95,3 +95,32 @@ def run_has_comments_pglike(self): | |||
| def test_postgres_comments(self): | |||
| self.run_has_comments_pglike() | |||
|
|
|||
| class TestPersistDocsColumnMissing(BasePersistDocsTest): | |||
There was a problem hiding this comment.
👍 Confirmed this test fails without the fix, and passes with it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4151
Description
As described in the issue, we just need to update the postgres/redshift adapter.
I reproduced the issue described in the issue:
With the fix, the
dbt runpass:And the wrong fiied is not persisted:
Checklist
CHANGELOG.mdand added information about my change