Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test name standardization #4509

Merged
merged 12 commits into from
Jan 4, 2022
Merged

test name standardization #4509

merged 12 commits into from
Jan 4, 2022

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Dec 17, 2021 •
edited
Loading

resolves #3648

Description

  • renamed test directories to all use _tests
  • removed files that were never referenced
  • fixed some typos

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Dec 17, 2021
@emmyoop emmyoop force-pushed the er/test-name-standardization branch from 045a7fc to 9d525ec Compare January 3, 2022 17:08
@emmyoop emmyoop added the test all run tests for all python versions + systems label Jan 4, 2022
@emmyoop emmyoop closed this Jan 4, 2022
@emmyoop emmyoop reopened this Jan 4, 2022
@emmyoop emmyoop marked this pull request as ready for review January 4, 2022 16:06
@emmyoop emmyoop force-pushed the er/test-name-standardization branch from 9509cd3 to 00fdb0a Compare January 4, 2022 16:10
@emmyoop emmyoop requested a review from gshank January 4, 2022 16:30
gshank
gshank approved these changes Jan 4, 2022
View reviewed changes
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@emmyoop emmyoop merged commit 1d25b2b into main Jan 4, 2022
@emmyoop emmyoop deleted the er/test-name-standardization branch January 4, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gshank gshank gshank approved these changes

Assignees
No one assigned
Labels
cla:yes test all run tests for all python versions + systems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update naming conventions for automated tests
2 participants
@emmyoop @gshank