Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Python <3.7.2 #4643

Merged
merged 4 commits into from
Jan 31, 2022
Merged

Drop support for Python <3.7.2 #4643

merged 4 commits into from
Jan 31, 2022

Conversation

jtcohen6
Copy link
Contributor

@jtcohen6 jtcohen6 commented Jan 28, 2022

[v1.1.0]

follow-up to #4585 (comment)

Description

  • Update core/setup.py to require >=3.7.2
  • Add changelog entry
  • Remove root-level setup.py since it no longer serves any purpose. pip install git+https://github.com/dbt-labs/dbt-core was already broken thanks to the error message raised for dbt==1.0.0 at build time

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@jtcohen6 jtcohen6 requested a review from a team as a code owner January 28, 2022 16:15
@jtcohen6 jtcohen6 requested review from VersusFacit and removed request for a team January 28, 2022 16:15
@cla-bot cla-bot bot added the cla:yes label Jan 28, 2022
Copy link
Contributor

@nathaniel-may nathaniel-may left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtcohen6 jtcohen6 merged commit 638e3ad into main Jan 31, 2022
@jtcohen6 jtcohen6 deleted the fix/py372-drop-support branch January 31, 2022 16:31
iknox-fa pushed a commit that referenced this pull request Feb 8, 2022
* Drop support for 3.7.1 + 3.7.2

* Rm root level setup.py

* Rm 'dbt' pkg from build-dist script

* Fixup changelog

automatic commit by git-black, original commits:
  638e3ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants