route logs to dbt-core/logs instead of each test folder #4711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoop
requested review from
ChenyuLInx and
iknox-fa
and removed request for
a team
gshank
requested changes
Feb 10, 2022
core/dbt/tests/fixtures/project.py
Outdated
| @@ -12,6 +15,8 @@ | |||
|
|
|||
| # These are the fixtures that are used in dbt core functional tests | |||
|
|
|||
| INITIAL_ROOT = os.getcwd() | |||
There was a problem hiding this comment.
There's a builtin pytest fixture thing that you can use instead of this INITIAL_ROOT variable: request.config.rootdir. If you add the 'request' fixture to the signature of the 'logs_dir' fixture, that should work.
…into er/testing-rewrite-logging # Conflicts: # core/dbt/tests/fixtures/project.py
gshank
force-pushed
the
testing_rewrite
branch
from
db991c9
to
507184f
Compare
emmyoop
requested review from
gshank
and removed request for
a team and
leahwicz
|
Git seems confused because of my force push. I'm not sure what the best way to fix it is... I'd probably create a clean branch off of testing_rewrite and cherry-pick your commits onto that. |
|
@gshank I seem to have resolved the conflicts. |
gshank
approved these changes
Feb 10, 2022
gshank
added a commit
that referenced
this pull request
Feb 22, 2022
Author: Emily Rockman <emily.rockman@dbtlabs.com>
route logs to dbt-core/logs instead of each test folder (#4711)
* Initial pass at switching integration tests to pytest
* Reorganize dbt.tests.tables. Cleanup adapter handling
* Move run_sql to TestProjInfo and TableComparison.
Add comments, cleanup adapter schema setup
* Tweak unique_schema name generation
* Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4700
Description
Logs were routing to the folders the projects were crated in. I added the log-path config to the project so that logs are all written to
dbt-core/logsnow, same as where they were written with the current tests.Checklist
CHANGELOG.mdand added information about my change