Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CHANGELOG duplicate 1.0.2 section #4736

Closed
wants to merge 1 commit into from
Closed

Conversation

leahwicz
Copy link
Contributor

Description

We had a duplicate 1.0.2 section in the CHANGELOG and didn't add the section for the RC yet so just fixing that up

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@leahwicz leahwicz requested a review from a team as a code owner February 17, 2022 01:18
@cla-bot cla-bot bot added the cla:yes label Feb 17, 2022
@@ -19,36 +19,33 @@
- Drop support for Python 3.7.0 + 3.7.1 ([#4584](https://github.com/dbt-labs/dbt-core/issues/4584), [#4585](https://github.com/dbt-labs/dbt-core/pull/4585), [#4643](https://github.com/dbt-labs/dbt-core/pull/4643))
- Re-format codebase (except tests) using pre-commit hooks ([#3195](https://github.com/dbt-labs/dbt-core/issues/3195), [#4697](https://github.com/dbt-labs/dbt-core/pull/4697))
- Add deps module README ([#4686](https://github.com/dbt-labs/dbt-core/pull/4686/))
- Support click versions in the v7.x series ([#4681](https://github.com/dbt-labs/dbt-core/pull/4681))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change was under the 1.0.2 section which I didn't think was right (it hasn't been backported) so I moved it up to be under 1.1.0. @jtcohen6 just checking you didn't want this in 1.0.2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the tag. I would like this in 1.0.3. Reasoning originally stated in #4566 (comment):

there's good cause to make it in a v1.0 patch release, so that folks can upgrade to v1.0 for use with Airflow, and don't need to wait until v1.1. The change feels pretty low-stakes since click is only used by dbt init.

Open to disagreement, however

@emmyoop
Copy link
Member

emmyoop commented Feb 17, 2022

In some other work I noticed that this is included (commit and changelog line) in the 1.0.2rc1 but is listed under 1.0.2 in the CHANGELOG on main.

- A change in secret environment variables won't trigger a full reparse [#4650](https://github.com/dbt-labs/dbt-core/issues/4650) [4665](https://github.com/dbt-labs/dbt-core/pull/4665)

@leahwicz leahwicz closed this Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants