Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated index file to fix DAG errors for operations & work around null columns #4763

Merged
merged 3 commits into from
Feb 25, 2022

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Feb 22, 2022

resolves #4578

Description

This solves two separate and unrelated bugs.

  1. Add operations so that parent/child map can be resolved. Also add the ability to view operations so the associated SQL can be viewed. Previously operations linked to no where and caused the DAG to not render.

  2. Search results not filtering correctly in Databricks. This is actually a dbt-spark issue. This fix makes it so docs continue to work by checking for conditions that should never be true. Once the associated bug is resolved docs will continue to work as expected and will continue to work for all other adapters.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change

@cla-bot cla-bot bot added the cla:yes label Feb 22, 2022
@emmyoop
Copy link
Member Author

emmyoop commented Feb 24, 2022

PRs in dbt-docs

  • dbt-docs/247 - Search results not filtering correctly merged
  • dbt-docs/248 - Operations causing DAG to not render merged

@emmyoop emmyoop marked this pull request as ready for review February 24, 2022 21:24
@emmyoop emmyoop requested a review from a team as a code owner February 24, 2022 21:24
@emmyoop emmyoop changed the title updated index file to fix DAG errors for operations updated index file to fix DAG errors for operations & work around null columns Feb 24, 2022
@emmyoop emmyoop merged commit 673ad50 into main Feb 25, 2022
@emmyoop emmyoop deleted the er/ct-50-doc-on-run-hook branch February 25, 2022 19:02
@emmyoop emmyoop added the backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch label Feb 25, 2022
@github-actions
Copy link
Contributor

The backport to 1.0.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-4763-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 673ad50e21ea33c9130b5626d8bbc0710949e235
# Push it to GitHub
git push --set-upstream origin backport-4763-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest

Then, create a pull request where the base branch is 1.0.latest and the compare/head branch is backport-4763-to-1.0.latest.

emmyoop added a commit that referenced this pull request Feb 25, 2022
… around null columns (#4763)

* updated index file to fix DAG errors for operations

* update index file to reflect dbt-docs fixes

* add changelog
# Conflicts:
#	CHANGELOG.md
emmyoop added a commit that referenced this pull request Feb 28, 2022
… around null columns (#4763) (#4797)

* updated index file to fix DAG errors for operations

* update index file to reflect dbt-docs fixes

* add changelog
# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.0.latest Tag for PR to be backported to the 1.0.latest branch cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-50] dbt-docs bug fixes for v1.0.x
2 participants