Fix errors on Windows tests in new tests/functional #4767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests didn't fail. Also not failing on main now. |
gshank
force-pushed
the
pytest_fix_windows_tables
branch
2 times, most recently
from
90ee216
to
88e7626
Compare
gshank
changed the title
gshank
force-pushed
the
pytest_fix_windows_tables
branch
from
88e7626
to
6f90cc3
Compare
emmyoop
requested changes
Feb 24, 2022
core/dbt/tests/fixtures/project.py
Outdated
Comment on lines
218
to
219
| with open(path.join(name), "w", encoding="utf-8") as fp: | ||
| fp.write(data) |
There was a problem hiding this comment.
It looks like this is happening in multiple places. I don't want to lose why we're doing it this way (in 6 months). Could we pull it out to centralize this and add a comment as to why we do this?
There was a problem hiding this comment.
Excellent idea, and much more readable. Have created 'read_file' and 'write_file' functions.
emmyoop
approved these changes
Feb 25, 2022
Comment on lines
+76
to
+77
| # We need to explicitly use encoding="utf-8" because otherwise on | ||
| # Windows we'll get codepage 1252 and things might break |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4781
Fixing test failures in tests/functional/basic on Windows platforms.
Description
Instead of generic 'write' methods, use text write methods with utf-8 encoding.
Checklist
CHANGELOG.mdand added information about my change