Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport 4982 deps #5007

Merged
merged 5 commits into from
Apr 7, 2022
Merged

Backport 4982 deps #5007

merged 5 commits into from
Apr 7, 2022

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Apr 7, 2022

Backport #4982

Description

Auto backport failed for code divergence conflicts. Manually resolved conflicts and tested locally.

One tests had to be commented out.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have added information about my change to be included in the CHANGELOG.

@cla-bot cla-bot bot added the cla:yes label Apr 7, 2022
# This seems to be a testing issue though. Everything works when testes locally
# and the CompilationException get raised. Since we're refactoring these tests anyways
# I won't rewrite this one
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emmyoop
Copy link
Member Author

emmyoop commented Apr 7, 2022

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Apr 7, 2022

The cla-bot has been summoned, and re-checked this pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants