Store when default env vars are used in manifest #5589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-559-default-env-vars
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
emmyoop
changed the title
emmyoop
changed the title
emmyoop
force-pushed
the
er/ct-559-default-env-vars
branch
from
eeb3325
to
9b20dd6
Compare
emmyoop
requested review from
nathaniel-may,
lostmygithubaccount and
gshank
and removed request for
a team,
nathaniel-may and
lostmygithubaccount
gshank
approved these changes
Aug 2, 2022
core/dbt/logger.py
Outdated
| @@ -32,6 +32,7 @@ | |||
| ) | |||
|
|
|||
| SECRET_ENV_PREFIX = "DBT_ENV_SECRET_" | |||
| DEFAULT_ENV_PLACEHOLDER = "DBT_DEFAULT_PLACEHOLDER" | |||
There was a problem hiding this comment.
When it was just the SECRET_ENV_PREFIX, it felt kind of okay to have it in the logger file. But I'm not sure it does now. Can you think of a better place to put them? Particularly since eventually we do intend to get rid of logger.py...
VersusFacit
pushed a commit
that referenced
this pull request
Sep 5, 2022
* WIP * handle defauly env vars * fix typo * add changelog * small fixes * add constants.py file
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
* WIP * handle defauly env vars * fix typo * add changelog * small fixes * add constants.py file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5155
Description
Checklist
changie newto create a changelog entry