Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop test_previous_version_state.py from modifying test data #5604

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Stop test_previous_version_state.py from modifying test data #5604

merged 1 commit into from
Aug 3, 2022

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Aug 2, 2022

resolves #5584

Description

An artifact test was modifying the test data. Comment out line that was doing it.

Checklist

@gshank
Comment out line to generate new manifest in
8338221 
test_previous_version_state.py
@gshank gshank added the Skip Changelog Skips GHA to check for changelog file label Aug 2, 2022
@gshank gshank requested a review from a team as a code owner August 2, 2022 22:01
@cla-bot cla-bot bot added the cla:yes label Aug 2, 2022
ChenyuLInx
ChenyuLInx approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems like this could causing some really odd behavior

@gshank gshank merged commit 7886924 into main Aug 3, 2022
@gshank gshank deleted the ct-062-artifact_test_data branch August 3, 2022 18:18
VersusFacit pushed a commit that referenced this pull request Sep 5, 2022
@gshank @VersusFacit
Comment out line to generate new manifest in test_previous_version_st…
2fbae56 
…ate.py (#5604)
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
@gshank
Comment out line to generate new manifest in test_previous_version_st…
d9fd59a 
…ate.py (dbt-labs#5604)
@dbeatty10 dbeatty10 mentioned this pull request Dec 20, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may nathaniel-may was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-962] artifact test modifies the test data
3 participants
@gshank @emmyoop @ChenyuLInx