Change postgres name truncation logic to be overridable. #5656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n with debugging instructions.
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
gshank
approved these changes
Aug 17, 2022
leahwicz
added
the
backport 1.2.latest
github-actions bot
pushed a commit
that referenced
this pull request
Aug 18, 2022
* Change postgres name truncation logic to be overridable. Add exception with debugging instructions. * Add changelog. Co-authored-by: Mila Page <versusfacit@users.noreply.github.com> (cherry picked from commit 0d02446)
VersusFacit
added a commit
that referenced
this pull request
Sep 5, 2022
* Change postgres name truncation logic to be overridable. Add exception with debugging instructions. * Add changelog. Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
Sep 16, 2022
* Change postgres name truncation logic to be overridable. Add exception with debugging instructions. * Add changelog. Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
josephberni
pushed a commit
to Gousto/dbt-core
that referenced
this pull request
Sep 16, 2022
* Change postgres name truncation logic to be overridable. Add exception with debugging instructions. * Add changelog. Co-authored-by: Mila Page <versusfacit@users.noreply.github.com>
lialzm
pushed a commit
to lialzm/dbt-core
that referenced
this pull request
Mar 11, 2023
…) (dbt-labs#5681) * Change postgres name truncation logic to be overridable. Add exception with debugging instructions. * Add changelog. Co-authored-by: Mila Page <versusfacit@users.noreply.github.com> (cherry picked from commit 0d02446) Co-authored-by: Mila Page <67295367+VersusFacit@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5586
Description
Redshift locally drawing from postgres verified to not run into collisions for models <119 chars. At that level, database limits lead to warehouse caused cache errors. I added an exception message for this case to help users in this case along. It'll be rare in the Redshift case (127 char limit) but not necessarily postgres (63 char limit).
To make sure this worked on the Redshift adapter, I triggered the error, fixed in, then increased local model name lengths to 127 which as expected retriggered the error.
Redshift followup PR.
Checklist
changie newto create a changelog entry