-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print more information on log line interop test failures #5659
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Rust looks fine from what I know of rust, logic seems fair, curious about the possible weakening though.
@McKnight-42 the risk with changing tests like this is that they could be accidentally modified to fail less often. I've frequently found tests in old code bases that could never fail which are obviously not good tests. I don't think this modification falls into that category, but I wanted to call it out as something for reviewers to look for since we're modifying a test. |
Print more information on log line interop test failures
Print more information on log line interop test failures
Print more information on log line interop test failures (cherry picked from commit 739fb98)
resolves #5658
Description
Adds more information to std out when these log tests fail. Also refactors the code to be higher quality.
Reviewers
This has a few whitespace changes. My non-whitespace changes start at 167 of the original. You can start at
test_deserialize_serialize_is_unchanged
which is the test. This calls the helper functions that have been modified.The biggest risk of this change is that I could have weakened the test so it would pass in more situations. I, of course, don't suspect this is the case but it should be verified by the reviewer.
Checklist
changie new
to create a changelog entry