Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print more information on log line interop test failures #5659

Merged
merged 4 commits into from
Aug 16, 2022

Conversation

nathaniel-may
Copy link
Contributor

@nathaniel-may nathaniel-may commented Aug 16, 2022

resolves #5658

Description

Adds more information to std out when these log tests fail. Also refactors the code to be higher quality.

Reviewers

This has a few whitespace changes. My non-whitespace changes start at 167 of the original. You can start at test_deserialize_serialize_is_unchanged which is the test. This calls the helper functions that have been modified.

The biggest risk of this change is that I could have weakened the test so it would pass in more situations. I, of course, don't suspect this is the case but it should be verified by the reviewer.

Checklist

@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Rust looks fine from what I know of rust, logic seems fair, curious about the possible weakening though.

@nathaniel-may nathaniel-may merged commit 739fb98 into main Aug 16, 2022
@nathaniel-may nathaniel-may deleted the nate/better-log-test-failures branch August 16, 2022 20:30
@nathaniel-may
Copy link
Contributor Author

@McKnight-42 the risk with changing tests like this is that they could be accidentally modified to fail less often. I've frequently found tests in old code bases that could never fail which are obviously not good tests. I don't think this modification falls into that category, but I wanted to call it out as something for reviewers to look for since we're modifying a test.

VersusFacit pushed a commit that referenced this pull request Sep 5, 2022
Print more information on log line interop test failures
agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request Sep 16, 2022
Print more information on log line interop test failures
@QMalcolm QMalcolm added the backport 1.2.latest This PR will be backported to the 1.2.latest branch label Feb 6, 2024
github-actions bot pushed a commit that referenced this pull request Feb 6, 2024
Print more information on log line interop test failures

(cherry picked from commit 739fb98)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.2.latest This PR will be backported to the 1.2.latest branch cla:yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1042] Improve unhelpful log line checks
4 participants