Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert 037_external_references #6589

Merged
merged 1 commit into from
Jan 13, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Jan 12, 2023

resolves #6574

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label Jan 12, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Jan 12, 2023
@MichelleArk MichelleArk marked this pull request as ready for review January 12, 2023 14:44
@MichelleArk MichelleArk requested a review from a team as a code owner January 12, 2023 14:44
@MichelleArk MichelleArk added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label Jan 12, 2023
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

external_schema = unique_schema + 'z'
project.run_sql(f'create schema "{external_schema}"')
project.run_sql(f'create table "{external_schema}"."external" (id integer)')
project.run_sql(f'insert into "{external_schema}"."external" values (1), (2)')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are (1) and (2) placeholders?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are concrete values of id being inserted into the "{external_schema}"."external" table

@MichelleArk MichelleArk merged commit c40b488 into main Jan 13, 2023
@MichelleArk MichelleArk deleted the CT-1787/037_external_reference_tests branch January 13, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1787] 037_external_reference_tests
3 participants