convert adapter table materialization test #6595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
ChenyuLInx
commented
Jan 12, 2023
| {{ | ||
| config( | ||
| materialized = "table", | ||
| sort = 'first_name', |
There was a problem hiding this comment.
This is the only specific part for this test, otherwise we could actually remove it
MichelleArk
approved these changes
Jan 12, 2023
aranke
approved these changes
Jan 12, 2023
aranke
reviewed
Jan 12, 2023
| @@ -0,0 +1,97 @@ | |||
| import pytest | |||
There was a problem hiding this comment.
Nit: Rename file to test_table_materialization.py.
| return {'materialized.sql': model_sql} | ||
|
|
||
| def test_table_materialization_sort_dist_no_op(self, project): | ||
| # basic table mat test, sort and dist is not supported by postgres so the result table would still be same as input |
aranke
changed the title
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #6576
Description
move adapter ddl test to new test framework. Since it is adapter specific so moving to adapter folder
Checklist
changie newto create a changelog entry