Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cheeky performance improvement on big DAGs #6694

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Cheeky performance improvement on big DAGs #6694

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9f96087
Short-circuit set operations for nice speed boost
boxysean Jan 22, 2023
b9dbbf5
Add changelog
boxysean Jan 22, 2023
6f7dfce
Fix issue
boxysean Jan 22, 2023
446a9fc
Update .changes/unreleased/Under the Hood-20230122-215235.yaml
boxysean Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Under the Hood-20230122-215235.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Under the Hood
body: Small optimization on manifest parsing benefitting large DAGs
time: 2023-01-22T21:52:35.549814+01:00
custom:
Author: boxysean
Issue: "6697"
2 changes: 1 addition & 1 deletion core/dbt/graph/queue.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ def _find_new_additions(self) -> None:
queue and add them.
"""
for node, in_degree in self.graph.in_degree():
if not self._already_known(node) and in_degree == 0:
if in_degree == 0 and not self._already_known(node):
self.inner.put((self._scores[node], node))
self.queued.add(node)

Expand Down