Backport 6982 to 1.4.latest #7074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
|
@jtcohen6 do we plan to release an RC for this first? I hesitate to backport this without any tests |
|
@leahwicz Yes, we'd want to do an RC for this first. It's not very urgent, since it's solving for a pretty niche use case. We could wait to combine it with other bug fixes that need backporting for inclusion in v1.4.x (if any more do). |
leahwicz
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting to include in v1.4.x patch, by request: #6900 (comment)
I'm not sure why the backport action didn't work. I just cherry-picked this one manually.