Do not log traceback when log format is json #7973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
|
@ChenyuLInx Change itself seems fine to me
We've no longer been cutting patches of v1.0 and v1.1 (since they've reached EOL) - let's discuss offline if there's a need to do this? (Update: started this internal Slack thread to discuss) |
ChenyuLInx
requested review from
aaronraff and
peterallenwebb
and removed request for
aaronraff and
chrispasakarnis
peterallenwebb
approved these changes
Jul 7, 2023
ChenyuLInx
added
backport 1.0.latest
github-actions bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
* do not log traceback when log format is json * changelog (cherry picked from commit 283f716)
This was referenced Jul 7, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
* do not log traceback when log format is json * changelog (cherry picked from commit 283f716)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 7, 2023
* do not log traceback when log format is json * changelog (cherry picked from commit 283f716)
ChenyuLInx
added a commit
that referenced
this pull request
Jul 12, 2023
ChenyuLInx
added a commit
that referenced
this pull request
Jul 12, 2023
ChenyuLInx
added a commit
that referenced
this pull request
Jul 12, 2023
4 tasks
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7972
This is only for 1.3 and pre versions of dbt-core.
When calling
logger.debugwithexc_infoset to True, logger will actually print out the formatted log to stdout(?). We want to avoid it when we set log_format toJSONWill backport to 1.2 and 1.1 and 1.0 once this is merged.