Skip to content

Commit

Permalink
drop support for py37 (#474) (#502)
Browse files Browse the repository at this point in the history
* drop support for py37

* drop support for py37

(cherry picked from commit 85c1d19)

Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
  • Loading branch information
colin-rogers-dbt and mikealfare authored Jun 20, 2023
1 parent dc104d5 commit c971472
Show file tree
Hide file tree
Showing 7 changed files with 25 additions and 23 deletions.
6 changes: 6 additions & 0 deletions .changes/unreleased/Breaking Changes-20230530-165542.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Breaking Changes
body: Drop support for python 3.7
time: 2023-05-30T16:55:42.393416-04:00
custom:
Author: mikealfare
Issue: dbt-core/7082
2 changes: 1 addition & 1 deletion .github/scripts/integration-test-matrix.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = ({ context }) => {
const defaultPythonVersion = "3.8";
const supportedPythonVersions = ["3.7", "3.8", "3.9", "3.10", "3.11"];
const supportedPythonVersions = ["3.8", "3.9", "3.10", "3.11"];
const supportedAdapters = ["redshift"];

// if PR, generate matrix based on files changed and PR labels
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python-version: ['3.8', '3.9', '3.10', '3.11']

env:
TOXENV: "unit"
Expand Down Expand Up @@ -175,7 +175,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ['3.7', '3.8', '3.9', '3.10', '3.11']
python-version: ['3.8', '3.9', '3.10', '3.11']

steps:
- name: Set up Python ${{ matrix.python-version }}
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ $EDITOR test.env
There are a few methods for running tests locally.

#### `tox`
`tox` takes care of managing Python virtualenvs and installing dependencies in order to run tests. You can also run tests in parallel. For example, you can run unit tests for Python 3.7, Python 3.8, Python 3.9, Python 3.10, and `flake8` checks in parallel with `tox -p`. Also, you can run unit tests for specific python versions with `tox -e py37`. The configuration of these tests are located in `tox.ini`.
`tox` takes care of managing Python virtualenvs and installing dependencies in order to run tests. You can also run tests in parallel. For example, you can run unit tests for Python 3.8, Python 3.9, Python 3.10, and `flake8` checks in parallel with `tox -p`. Also, you can run unit tests for specific python versions with `tox -e py38`. The configuration of these tests are located in `tox.ini`.

#### `pytest`
Finally, you can also run a specific test or group of tests using `pytest` directly. With a Python virtualenv active and dev dependencies installed you can do things like:
Expand Down
21 changes: 9 additions & 12 deletions dev-requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,28 +6,25 @@ git+https://github.com/dbt-labs/dbt-core.git@1.5.latest#egg=dbt-postgres&subdire

# if version 1.x or greater -> pin to major version
# if version 0.x -> pin to minor
black~=23.1
black~=23.3
bumpversion~=0.6.0
click~=8.1
flake8~=5.0;python_version=="3.7"
flake8~=6.0;python_version>="3.8"
flake8~=6.0
flaky~=3.7
freezegun~=1.2
ipdb~=0.13.13
mypy==1.1.1 # patch updates have historically introduced breaking changes
pip-tools~=6.12
pre-commit~=2.21;python_version=="3.7"
pre-commit~=3.2;python_version>="3.8"
mypy==1.2.0 # patch updates have historically introduced breaking changes
pip-tools~=6.13
pre-commit~=3.2
pre-commit-hooks~=4.4
pytest~=7.2
pytest~=7.3
pytest-csv~=3.0
pytest-dotenv~=0.5.2
pytest-logbook~=1.2
pytest-xdist~=3.2
pytz~=2023.2
tox~=3.0;python_version=="3.7"
tox~=4.4;python_version>="3.8"
types-pytz~=2023.2
pytz~=2023.3
tox~=4.5
types-pytz~=2023.3
types-requests~=2.28
twine~=4.0
wheel~=0.40
7 changes: 3 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
#!/usr/bin/env python
import sys

if sys.version_info < (3, 7):
if sys.version_info < (3, 8):
print("Error: dbt does not support this version of Python.")
print("Please upgrade to Python 3.7 or higher.")
print("Please upgrade to Python 3.8 or higher.")
sys.exit(1)


Expand Down Expand Up @@ -94,11 +94,10 @@ def _core_version(plugin_version: str = _plugin_version()) -> str:
"Operating System :: Microsoft :: Windows",
"Operating System :: MacOS :: MacOS X",
"Operating System :: POSIX :: Linux",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
"Programming Language :: Python :: 3.9",
"Programming Language :: Python :: 3.10",
"Programming Language :: Python :: 3.11",
],
python_requires=">=3.7",
python_requires=">=3.8",
)
6 changes: 3 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
[tox]
skipsdist = True
envlist = py37,py38,py39,py310,py311
envlist = py38,py39,py310,py311

[testenv:{unit,py37,py38,py39,py310,py311,py}]
[testenv:{unit,py38,py39,py310,py311,py}]
description = unit testing
skip_install = true
passenv =
Expand All @@ -13,7 +13,7 @@ deps =
-rdev-requirements.txt
-e.

[testenv:{integration,py37,py38,py39,py310,py311,py}-{redshift}]
[testenv:{integration,py38,py39,py310,py311,py}-{redshift}]
description = adapter plugin integration testing
skip_install = true
passenv =
Expand Down

0 comments on commit c971472

Please sign in to comment.