Skip to content

Commit

Permalink
drop support for py37 (#474)
Browse files Browse the repository at this point in the history
(cherry picked from commit 85c1d19)
  • Loading branch information
mikealfare committed Jun 29, 2023
1 parent 3e00294 commit d3745f0
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 11 deletions.
6 changes: 6 additions & 0 deletions .changes/unreleased/Breaking Changes-20230530-165542.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Breaking Changes
body: Drop support for python 3.7
time: 2023-05-30T16:55:42.393416-04:00
custom:
Author: mikealfare
Issue: dbt-core/7082
2 changes: 1 addition & 1 deletion .github/scripts/integration-test-matrix.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module.exports = ({ context }) => {
const defaultPythonVersion = "3.8";
const supportedPythonVersions = ["3.7", "3.8"];
const supportedPythonVersions = ["3.8"];
const supportedAdapters = ["redshift"];

// if PR, generate matrix based on files changed and PR labels
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
strategy:
fail-fast: false
matrix:
python-version: [3.7, 3.8] # TODO: support unit testing for python 3.9 (https://github.com/dbt-labs/dbt/issues/3689)
python-version: [3.8] # TODO: support unit testing for python 3.9 (https://github.com/dbt-labs/dbt/issues/3689)

env:
TOXENV: "unit"
Expand Down Expand Up @@ -178,7 +178,7 @@ jobs:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
python-version: ['3.7', '3.8']
python-version: ['3.8']

steps:
- name: Set up Python ${{ matrix.python-version }}
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.MD
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ $EDITOR test.env
There are a few methods for running tests locally.

#### `tox`
`tox` takes care of managing Python virtualenvs and installing dependencies in order to run tests. You can also run tests in parallel. For example, you can run unit tests for Python 3.7, Python 3.8, Python 3.10, and `flake8` checks in parallel with `tox -p`. Also, you can run unit tests for specific python versions with `tox -e py37`. The configuration of these tests are located in `tox.ini`.
`tox` takes care of managing Python virtualenvs and installing dependencies in order to run tests. You can also run tests in parallel. For example, you can run unit tests for Python 3.8, Python 3.10, and `flake8` checks in parallel with `tox -p`. Also, you can run unit tests for specific python versions with `tox -e py38`. The configuration of these tests are located in `tox.ini`.

#### `pytest`
Finally, you can also run a specific test or group of tests using `pytest` directly. With a Python virtualenv active and dev dependencies installed you can do things like:
Expand Down
7 changes: 3 additions & 4 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
import re

# require python 3.7 or newer
if sys.version_info < (3, 7):
if sys.version_info < (3, 8):
print('Error: dbt does not support this version of Python.')
print('Please upgrade to Python 3.7 or higher.')
print('Please upgrade to Python 3.8 or higher.')
sys.exit(1)


Expand Down Expand Up @@ -83,9 +83,8 @@ def _get_dbt_core_version():
'Operating System :: MacOS :: MacOS X',
'Operating System :: POSIX :: Linux',

'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
],
python_requires=">=3.7",
python_requires=">=3.8",
)
6 changes: 3 additions & 3 deletions tox.ini
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tox]
skipsdist = True
envlist = py37,py38,py39,flake8
envlist = py38,py39,flake8

[testenv:flake8]
description = flake8 code checks
Expand All @@ -11,7 +11,7 @@ commands = flake8 --select=E,W,F --ignore=W504,E741 --max-line-length 99 \
deps =
-rdev_requirements.txt

[testenv:{unit,py37,py38,py39,py}]
[testenv:{unit,py38,py39,py}]
description = unit testing
skip_install = true
passenv =
Expand All @@ -22,7 +22,7 @@ deps =
-rdev_requirements.txt
-e.

[testenv:{integration,py37,py38,py39,py}-{redshift}]
[testenv:{integration,py38,py39,py}-{redshift}]
description = adapter plugin integration testing
skip_install = true
passenv =
Expand Down

0 comments on commit d3745f0

Please sign in to comment.