Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add query commenting back #537

Merged
merged 1 commit into from
Jul 14, 2023
Merged

add query commenting back #537

merged 1 commit into from
Jul 14, 2023

Conversation

dataders
Copy link
Contributor

@dataders dataders commented Jul 13, 2023 •
edited by dbeatty10
Loading

resolves #536

No docs updates needed.

Problem

this gist shows that sql = self._add_query_comment(sql) was removed as part of #251. and never added back. this omission was not picked up due to faulty tests that were surfaced in dbt-labs/dbt-core#7845 and fixed in dbt-labs/dbt-core#7928.

Solution

Add it back 😎

Vive les commentaires de requête !

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • Tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc)

@cla-bot cla-bot bot added the cla:yes label Jul 13, 2023
@dataders dataders marked this pull request as ready for review July 13, 2023 23:41
@dataders dataders requested a review from a team as a code owner July 13, 2023 23:41
@dataders dataders requested a review from mikealfare July 13, 2023 23:42
@mikealfare mikealfare merged commit 5958da3 into main Jul 14, 2023
35 checks passed
@mikealfare mikealfare deleted the add-back-missing-query-comment branch July 14, 2023 00:39
github-actions bot pushed a commit that referenced this pull request Jul 14, 2023
@dataders @github-actions
add query commenting back (#537)
abb0ff4 
(cherry picked from commit 5958da3)
@github-actions github-actions bot mentioned this pull request Jul 14, 2023
Merged
@dbeatty10 dbeatty10 mentioned this pull request Jul 14, 2023
Closed
colin-rogers-dbt added a commit that referenced this pull request Jul 31, 2023
@github-actions @dataders @colin-rogers-dbt
add query commenting back (#537) (#538)
3f16d20 
(cherry picked from commit 5958da3)

Co-authored-by: Anders <anders.swanson@dbtlabs.com>
Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>
abbywh pushed a commit to abbywh/dbt-redshift that referenced this pull request Oct 11, 2023
@dataders
add query commenting back (dbt-labs#537)
c353e55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

@dbeatty10 dbeatty10 dbeatty10 approved these changes

Assignees
No one assigned
Labels
cla:yes ok to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ADAP-701] [Regression] query commenting is not possible from 1.5.0 onwards
3 participants
@dataders @mikealfare @dbeatty10