Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove group_federation for serverless #836

Merged
merged 16 commits into from
Jun 13, 2024
Merged

Remove group_federation for serverless #836

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
9cb824e
Remove grou_federation for serverless
Fleid May 31, 2024
334b118
Add changie log
Fleid May 31, 2024
145b3cc
Fix test on cluster_id
Fleid May 31, 2024
00c53d6
Add explicit role_arn support
Fleid May 31, 2024
a3f5f3c
Revert "Add explicit role_arn support"
Fleid Jun 11, 2024
cd86483
Add tests
Fleid Jun 11, 2024
073b7b1
Linting
Fleid Jun 11, 2024
b696109
Linting
Fleid Jun 11, 2024
9fe57e3
Tests should ignore group_federation, and not expect false
Fleid Jun 11, 2024
92744af
Pick the correct method for the test
Fleid Jun 11, 2024
0da52a8
db_user should line up with IAMRole on Provisionned
Fleid Jun 11, 2024
552137d
Align tests to spec
Fleid Jun 11, 2024
5c4c636
Explicitely set group federation for serverless
Fleid Jun 11, 2024
6c07d46
Solved the cluster id issue - should be null on serverless
Fleid Jun 11, 2024
46dc649
Update changie desc
Fleid Jun 12, 2024
3bf3a75
Merge branch 'main' into serverless_group_federation
colin-rogers-dbt Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20240531-113620.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: Remove group_federation when using serverless for iam authentication
Fleid marked this conversation as resolved.
Show resolved Hide resolved
time: 2024-05-31T11:36:20.397521-07:00
custom:
Author: fleid
Issue: "835"
11 changes: 7 additions & 4 deletions dbt/adapters/redshift/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,10 +234,13 @@ def _iam_user_kwargs(self) -> Dict[str, Any]:
def _iam_role_kwargs(self) -> Dict[str, Optional[Any]]:
logger.debug("Connecting to redshift with 'iam_role' credentials method")
kwargs = self._iam_kwargs
kwargs.update(
group_federation=True,
db_user=None,
)

# It's a role, we're ignoring the user
kwargs.update(db_user=None)

# Serverless shouldn't get group_federation, Provisoned clusters should
if self.credentials.cluster_id:
kwargs.update(group_federation=True)

if iam_profile := self.credentials.iam_profile:
kwargs.update(profile=iam_profile)
Expand Down
Loading