Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isolating distribution testing #1161

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

leahwicz
Copy link
Contributor

@leahwicz leahwicz commented Aug 7, 2024

resolves #1130

Problem

We validate wheel and source distributions in the same environment during the build validation step. This led to issues documented here dbt-labs/dbt-core#10465.

Solution

This splits out the wheel and source installation and testing into their own Action's job to test

This is a test run of the Action running with the installation and testing of wheels and source distributions split into separate Actions Jobs that isolate them from one another: https://github.com/leahwicz/dbt-snowflake/actions/runs/10276531967/job/28437083967

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@leahwicz leahwicz requested a review from a team as a code owner August 7, 2024 01:57
@cla-bot cla-bot bot added the cla:yes label Aug 7, 2024
@leahwicz leahwicz closed this Aug 9, 2024
@leahwicz leahwicz reopened this Aug 9, 2024
@mikealfare
Copy link
Contributor

@leahwicz Nice try on re-running the tests. The problem is that the change is only a workflow file and we filter on those for running this test. An admin needs to override it. Alternatively, we should probably just remove that from the filter since it's completely reasonable for a PR to only be workflow updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the build check workflow
3 participants