Enforce server side parameters to be strings (#827)

* Enfore server side parameters to be strings

* Add changie

* Iterate over items

* Test for casting server_side_parameters to strings

---------

Co-authored-by: colin-rogers-dbt <111200756+colin-rogers-dbt@users.noreply.github.com>

.changes/unreleased/Features-20230707-114650.yaml

@@ -0,0 +1,6 @@
+kind: Features
+body: Enforce server side parameters keys and values to be strings
+time: 2023-07-07T11:46:50.390918+02:00
+custom:
+  Author: Fokko,JCZuurmond
+  Issue: "826"

dbt/adapters/spark/connections.py

@@ -73,7 +73,7 @@ class SparkCredentials(Credentials):
     connect_retries: int = 0
     connect_timeout: int = 10
     use_ssl: bool = False
-    server_side_parameters: Dict[str, Any] = field(default_factory=dict)
+    server_side_parameters: Dict[str, str] = field(default_factory=dict)
     retry_all: bool = False
 
     @classmethod
@@ -142,6 +142,10 @@ def __post_init__(self) -> None:
         if self.method != SparkConnectionMethod.SESSION:
             self.host = self.host.rstrip("/")
 
+        self.server_side_parameters = {
+            str(key): str(value) for key, value in self.server_side_parameters.items()
+        }
+
     @property
     def type(self) -> str:
         return "spark"

tests/unit/test_credentials.py

@@ -0,0 +1,12 @@
+from dbt.adapters.spark.connections import SparkConnectionMethod, SparkCredentials
+
+
+def test_credentials_server_side_parameters_keys_and_values_are_strings() -> None:
+    credentials = SparkCredentials(
+        host="localhost",
+        method=SparkConnectionMethod.THRIFT,
+        database="tests",
+        schema="tests",
+        server_side_parameters={"spark.configuration": 10},
+    )
+    assert credentials.server_side_parameters["spark.configuration"] == "10"