Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests #3

Closed
drewbanin opened this issue Mar 21, 2019 · 3 comments
Closed

Add integration tests #3

drewbanin opened this issue Mar 21, 2019 · 3 comments

Comments

@drewbanin
Copy link
Contributor

No description provided.

jtcohen6 pushed a commit that referenced this issue Feb 3, 2020
@dmateusp
Copy link
Contributor

dmateusp commented Mar 8, 2020

hey @jtcohen6 from what I can see, integration tests were added to the Circleci ? https://github.com/fishtown-analytics/dbt-spark/blob/master/.circleci/config.yml#L16

Also would it be possible to report the status on those circleci builds to PRs ?

@jtcohen6
Copy link
Contributor

jtcohen6 commented Mar 9, 2020

@dmateusp That's correct. For now, we're limiting CircleCI builds to run on commits that are pushed by organization (Fishtown) members. That means I can kick off tests for external contributors who open PRs, but it's a less-than-perfectly-automated process.

On PRs where I've kicked off Circle tests, you should be able to see their status. I'll kick them off on #58 now so you can see.

@jtcohen6
Copy link
Contributor

jtcohen6 commented Apr 2, 2020

The integration tests we have now are enough for a sanity check, and they should be running on every PR. The better, longer-term answer is going to come from work we do in dbt-core: dbt-labs/dbt-core#2204

@jtcohen6 jtcohen6 closed this as completed Apr 2, 2020
ChenyuLInx pushed a commit that referenced this issue Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants