Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CircleCI Context for AWS access key environment variables #582

Merged
merged 4 commits into from
Jan 6, 2023

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Jan 6, 2023

resolves #581

Description

Use a CircleCI Context for AWS access key environment variables.

Details

The names of contexts within CircleCI are chosen by the user, and they act like a named group of environment variables that can be "imported" within workflows so that the individual environment variables can be used within jobs.

In this case, we know that the name we gave this context is aws-credentials, and we can look it up here:
https://app.circleci.com/settings/organization/github/dbt-labs/contexts

Checklist

@cla-bot cla-bot bot added the cla:yes label Jan 6, 2023
@dbeatty10 dbeatty10 marked this pull request as ready for review January 6, 2023 02:19
@dbeatty10 dbeatty10 added the Skip Changelog Skips GHA to check for changelog file label Jan 6, 2023
@dbeatty10 dbeatty10 requested a review from emmyoop January 6, 2023 14:37
@dbeatty10
Copy link
Contributor Author

It got stuck when I tried adding [skip ci] to the commit message, and I don't have the superpowers to force the merge:
image

I'm made a trivial alteration to bump it along and re-run CI from scratch.

@dbeatty10 dbeatty10 merged commit d9a3d76 into main Jan 6, 2023
@dbeatty10 dbeatty10 deleted the dbeatty/circleci-context-aws-credentials branch January 6, 2023 15:46
@colin-rogers-dbt colin-rogers-dbt restored the dbeatty/circleci-context-aws-credentials branch January 20, 2023 19:42
github-actions bot pushed a commit that referenced this pull request Feb 1, 2023
* Use CircleCI Context for AWS access key environment variables

* Use the `aws-credentials` global context configured within CircleCI

* Remove changelog entry [skip ci]

* Remove extra space

(cherry picked from commit d9a3d76)
github-actions bot pushed a commit that referenced this pull request Feb 1, 2023
* Use CircleCI Context for AWS access key environment variables

* Use the `aws-credentials` global context configured within CircleCI

* Remove changelog entry [skip ci]

* Remove extra space

(cherry picked from commit d9a3d76)
nathaniel-may pushed a commit that referenced this pull request Feb 1, 2023
…ment variables (#628)

* Use CircleCI Context for AWS access key environment variables (#582)

* Use CircleCI Context for AWS access key environment variables

* Use the `aws-credentials` global context configured within CircleCI

* Remove changelog entry [skip ci]

* Remove extra space

(cherry picked from commit d9a3d76)

* retrigger checks

---------

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com>
nathaniel-may pushed a commit that referenced this pull request Feb 1, 2023
…ment variables (#627)

* Use CircleCI Context for AWS access key environment variables (#582)

* Use CircleCI Context for AWS access key environment variables

* Use the `aws-credentials` global context configured within CircleCI

* Remove changelog entry [skip ci]

* Remove extra space

(cherry picked from commit d9a3d76)

* retrigger checks

---------

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com>
@mikealfare mikealfare deleted the dbeatty/circleci-context-aws-credentials branch March 1, 2023 00:46
@github-actions
Copy link
Contributor

The backport to 1.0.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-582-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d9a3d76086e0b37a224f6eec84e5a8b2274bd3b7
# Push it to GitHub
git push --set-upstream origin backport-582-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest

Then, create a pull request where the base branch is 1.0.latest and the compare/head branch is backport-582-to-1.0.latest.

colin-rogers-dbt pushed a commit that referenced this pull request Jun 12, 2023
emmyoop pushed a commit that referenced this pull request Jun 12, 2023
@emmyoop emmyoop mentioned this pull request Jun 12, 2023
6 tasks
emmyoop added a commit that referenced this pull request Jun 12, 2023
* backport cce8975

* fix python action

* allow unit tests on
 py 3.7

* backport #582

---------

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1756] [Bug] Environment variables for AWS access keys have been removed
3 participants