-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CircleCI Context for AWS access key environment variables #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoop
reviewed
Jan 6, 2023
emmyoop
approved these changes
Jan 6, 2023
colin-rogers-dbt
restored the
dbeatty/circleci-context-aws-credentials
branch
January 20, 2023 19:42
github-actions bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
* Use CircleCI Context for AWS access key environment variables * Use the `aws-credentials` global context configured within CircleCI * Remove changelog entry [skip ci] * Remove extra space (cherry picked from commit d9a3d76)
github-actions bot
pushed a commit
that referenced
this pull request
Feb 1, 2023
* Use CircleCI Context for AWS access key environment variables * Use the `aws-credentials` global context configured within CircleCI * Remove changelog entry [skip ci] * Remove extra space (cherry picked from commit d9a3d76)
nathaniel-may
pushed a commit
that referenced
this pull request
Feb 1, 2023
…ment variables (#628) * Use CircleCI Context for AWS access key environment variables (#582) * Use CircleCI Context for AWS access key environment variables * Use the `aws-credentials` global context configured within CircleCI * Remove changelog entry [skip ci] * Remove extra space (cherry picked from commit d9a3d76) * retrigger checks --------- Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com>
nathaniel-may
pushed a commit
that referenced
this pull request
Feb 1, 2023
…ment variables (#627) * Use CircleCI Context for AWS access key environment variables (#582) * Use CircleCI Context for AWS access key environment variables * Use the `aws-credentials` global context configured within CircleCI * Remove changelog entry [skip ci] * Remove extra space (cherry picked from commit d9a3d76) * retrigger checks --------- Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Co-authored-by: Nathaniel May <nathaniel.may@fishtownanalytics.com>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-582-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d9a3d76086e0b37a224f6eec84e5a8b2274bd3b7
# Push it to GitHub
git push --set-upstream origin backport-582-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest Then, create a pull request where the |
colin-rogers-dbt
pushed a commit
that referenced
this pull request
Jun 12, 2023
6 tasks
emmyoop
added a commit
that referenced
this pull request
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #581
Description
Use a CircleCI Context for AWS access key environment variables.
Details
The names of contexts within CircleCI are chosen by the user, and they act like a named group of environment variables that can be "imported" within
workflows
so that the individual environment variables can be used withinjobs
.In this case, we know that the name we gave this context is
aws-credentials
, and we can look it up here:https://app.circleci.com/settings/organization/github/dbt-labs/contexts
Checklist
This PR includes tests, ortests are not required/relevant for this PRI have opened an issue to add/update docs, ordocs changes are not required/relevant for this PRchangie new
to create a changelog entry