Fix split part negative part number #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikealfare
reviewed
Mar 29, 2023
|
@mikealfare forgot to link the associated core PR that adds the necessary test case we are interested in. once that's in we can remove the pointer from the |
dbeatty10
reviewed
Jul 11, 2023
dbeatty10
reviewed
Jul 11, 2023
mikealfare
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #688
Description
Copies standard approach seen in other core adapters for handling negative arguments to
part_numberindbt.split_partdbt-labs/dbt-core#7200
Checklist
changie newto create a changelog entry