Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBT_INCLUDE_SAVED_QUERY -> DBT_EXPORT_SAVED_QUERIES #5018

Closed
1 task done
jtcohen6 opened this issue Feb 28, 2024 · 2 comments · Fixed by #5024
Closed
1 task done

DBT_INCLUDE_SAVED_QUERY -> DBT_EXPORT_SAVED_QUERIES #5018

jtcohen6 opened this issue Feb 28, 2024 · 2 comments · Fixed by #5024
Assignees
@matthewshaver @mirnawong1
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear semantic-layer-ga Label for new semantic layer GA launch
Milestone
dbt Core v1.8 Doc...

Comments

@jtcohen6
Copy link
Collaborator

jtcohen6 commented Feb 28, 2024 •
edited
Loading

Contributions

  • I have read the contribution docs, and understand what's expected of me.

Link to the page on docs.getdbt.com requiring updates

https://docs.getdbt.com/docs/use-dbt-semantic-layer/exports#define-exports
https://docs.getdbt.com/docs/dbt-versions/release-notes/Feb-2024/exports-rn

What part(s) of the page would you like to see updated?

  • Rename DBT_INCLUDE_SAVED_QUERY to DBT_EXPORT_SAVED_QUERIES. The old name still works, because we added backwards-compatibility, but the old name is confusing and the new name is more precise about what's happening.
    • This is ONLY relevant starting with "Keep on latest version" in dbt Cloud. Anyone still on v1.7 should keep using the previous name, DBT_INCLUDE_SAVED_QUERY.
  • Let's switch out "materialize" for "write." IMO the word "materialize" is confusing because it implies that saved query exports are being materialized using the same logic as dbt models materailizations, and they're not. @Jstein77 does that make sense to you?

Additional information
@jtcohen6 jtcohen6 added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear labels Feb 28, 2024
@jtcohen6 jtcohen6 added this to the dbt Core v1.8 Documentation milestone Feb 28, 2024
@matthewshaver matthewshaver self-assigned this Feb 29, 2024
@mirnawong1
Copy link
Contributor

mirnawong1 commented Feb 29, 2024 •
edited
Loading

hey @matthewshaver , i'm happy take this one as it relates to SL? cc @nghi-ly and @runleonarun

@mirnawong1 mirnawong1 self-assigned this Feb 29, 2024
@mirnawong1
Copy link
Contributor

hey @jtcohen6 , does keep on latest version mean 'v1.7 and higher'? or 'v1.8 or higher'?

@mirnawong1 mirnawong1 mentioned this issue Feb 29, 2024
Merged
@runleonarun runleonarun added dbt Core The changes proposed in this issue relate to dbt Core semantic-layer-ga Label for new semantic layer GA launch labels Mar 13, 2024
mirnawong1 added a commit that referenced this issue Mar 14, 2024
@mirnawong1
add DBT_EXPORT_SAVED_QUERIES (#5024)
6e48310 
- Rename DBT_INCLUDE_SAVED_QUERY to DBT_EXPORT_SAVED_QUERIES
- switch out "materialize" for "write in various pages such as
'exports', 'saved queries', and the 'exports release note'

cc @Jstein77 @jtcohen6 and @matthewshaver 

Resolves #5018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewshaver matthewshaver

@mirnawong1 mirnawong1

Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear semantic-layer-ga Label for new semantic layer GA launch
Projects
None yet
Milestone
dbt Core v1.8 Documentation
Development

Successfully merging a pull request may close this issue.

add DBT_EXPORT_SAVED_QUERIES dbt-labs/docs.getdbt.com
4 participants
@runleonarun @jtcohen6 @matthewshaver @mirnawong1