Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Fuzzy Wuzzy from MetricFlow #470

Closed
callum-mcdata opened this issue Apr 26, 2023 · 0 comments
Closed

Remove Fuzzy Wuzzy from MetricFlow #470

callum-mcdata opened this issue Apr 26, 2023 · 0 comments
Labels
enhancement New feature or request triage Tasks that need to be triaged

Comments

@callum-mcdata
Copy link
Contributor

Describe the Feature
Fuzzy Wuzzy has a GPL license, which is not compatible with BSL. As such, we need to remove our dependency on it.

Would you like to contribute?
Potentially!
@callum-mcdata callum-mcdata added enhancement New feature or request triage Tasks that need to be triaged labels Apr 26, 2023
This was referenced Apr 26, 2023
Closed
Merged
callum-mcdata added a commit that referenced this issue Apr 27, 2023
@callum-mcdata
Changing to RapidFuzz from FuzzyWuzzy (#474)
661e663 
Resolves #471 and #470 (as 471 is a dependency within 470)

Given #465 , we need to remove our dependency on FuzzyWuzzy. I found an alternative library called RapidFuzz that has the same APIs but with an MIT license and supposedly increased performance.

@tlento and his eagle eyes also noted that we have to hard-pin GitPython in order to resolve test failures with the migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request triage Tasks that need to be triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@callum-mcdata