Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include metric_time in list dimensions output where appropriate #673

Closed
3 tasks done
tlento opened this issue Jul 24, 2023 · 0 comments · Fixed by #676
Closed
3 tasks done

Include metric_time in list dimensions output where appropriate #673

tlento opened this issue Jul 24, 2023 · 0 comments · Fixed by #676
Labels
enhancement New feature or request triage Tasks that need to be triaged

Comments

@tlento
Copy link
Contributor

tlento commented Jul 24, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing metricflow functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Currently, running mf list dimensions looks something like this:

$ mf list dimensions --metrics jumbo_orders
✔ 🌱 We've found 12 common dimensions for metrics ['jumbo_orders'].
• location_name
• ds
• is_food_order
• is_drink_order
• order_total_dim
• is_large_order
• customer_name
• count_lifetime_orders
• lifetime_spend
• customer_type
• first_ordered_at
• last_ordered_at

The thing is, ds is the underlying dimension name for the aggregation time dimension for jumbo_orders, which can also be accessed via the metric_time alias, but unless the calling user has read our documentation and remembers that metric_time is the name to use, they might not realize that the best way to query this metric - particularly if the query includes other metrics with different aggregation time dimensions - is to use the metric_time alias.

Ideally we'd include metric_time in this output list somewhere. For now, it's probably sufficient to simply hard-code the dimension name in the list, but ideally this would be something we could resolve.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@tlento tlento added enhancement New feature or request triage Tasks that need to be triaged labels Jul 24, 2023
plypaul added a commit that referenced this issue Jul 25, 2023
plypaul added a commit that referenced this issue Jul 27, 2023
plypaul added a commit that referenced this issue Jul 27, 2023
plypaul added a commit that referenced this issue Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Tasks that need to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant