Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax version pins on production dependencies #707

Closed
3 tasks done
tlento opened this issue Aug 3, 2023 · 1 comment · Fixed by #720
Closed
3 tasks done

Relax version pins on production dependencies #707

tlento opened this issue Aug 3, 2023 · 1 comment · Fixed by #720
Labels
enhancement New feature or request triage Tasks that need to be triaged

Comments

@tlento
Copy link
Contributor

tlento commented Aug 3, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing metricflow functionality, rather than a Big Idea better suited to a discussion

Describe the feature

MetricFlow still has a number of internal dependencies with version pins to specific versions. In particular:

  "MarkupSafe==2.0.1",
  "graphviz==0.18.2",
  "jsonschema==3.2.0",
  "more-itertools==8.10.0",
  "python-dateutil==2.8.2",
  "rapidfuzz==3.0.0",

These should be relaxed as far as we are able. jsonschema, more-itertools, python-dateutil, and rapidfuzz are probably the most critical production dependencies on that list.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@tlento tlento added enhancement New feature or request triage Tasks that need to be triaged labels Aug 3, 2023
@tlento tlento linked a pull request Aug 10, 2023 that will close this issue
@davidmathers
Copy link

The linked pull request won't close this issue

werkzeug 2.2.3 requires MarkupSafe>=2.1.1, but you have markupsafe 2.0.1 which is incompatible.

MarkupSafe 2.1.1 was released March 15, 2022

MarkupSafe 2.0.1 was released May 18, 2021

Please don't pin dependencies that are 2.5 years old

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage Tasks that need to be triaged
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants