Loosen version pins for MetricFlow dependencies #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Our use of GraphViz is compatible with a much broader range than originally specified. This has been tested in the CLI and we can render plans with 0.20.1.
Several packages have strict version pins that are not necessary, as our usage is compatible with a broad range of versions. These updated version ranges all appear to be safe with MetricFlow's current usage and dependency requirements.
MetricFlow's jsonschema dependency was a holdover from the days when it was a monolithic package supporting both open source and Transform internal use cases. The last remaining dependency was jsonschema parsing support for some Transform-specific attributes, which are no longer in use. This removes all explicit jsonschema dependencies, instead relying on dbt-semantic-interfaces for managing the relevant package installation requirements.
3 tasks
tlento
force-pushed
the
loosen-dep-versions
branch
from
e6c3226
to
39c9cde
Compare
This was referenced Aug 15, 2023
plypaul
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several packages have strict version pins that are not necessary,
as our usage is compatible with a broad range of versions. These
updated version ranges all appear to be safe with MetricFlow's
current usage and dependency requirements.
This also removes our vestigial jsonschema dependencies.