Move model validator and rules to dbt_semantic_interfaces #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlento
reviewed
May 10, 2023
plypaul
force-pushed
the
plypaul--11--rename-metric-constraint
branch
from
9d9eb0a
to
b723674
Compare
QMalcolm
force-pushed
the
qmalcolm--dbt-si-move-validations
branch
from
a385dee
to
9474433
Compare
QMalcolm
force-pushed
the
qmalcolm--dbt-si-move-validations
branch
from
9474433
to
0a070b8
Compare
This import worked because there is a time_granularity file in MetricFlow and it imports TimeGranularity from dbt_semantic_interfaces (thus making it available). However importing it from MetricFlow in dbt_semantic_interfaces was problematic for multiple reasons 1) It created a circular dependency, and the ProcessPoolExecutor or model validator freaked out about this 2) dbt_semantic_interfaces cannot depend on MetricFlow
QMalcolm
force-pushed
the
qmalcolm--dbt-si-move-validations
branch
from
0a070b8
to
113396b
Compare
tlento
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #481
Description
Validations are going to be part of dbt-semantic-interfaces. This makes it so 🙂