Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dependencies to dbt-semantic-interfaces~=0.3.0 #809

Merged
merged 3 commits into from
Oct 13, 2023

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Oct 12, 2023

Description

As per title.

@cla-bot cla-bot bot added the cla:yes label Oct 12, 2023
@plypaul plypaul marked this pull request as ready for review October 12, 2023 22:11
@plypaul plypaul requested a review from tlento October 12, 2023 22:11
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so Postgres (and DuckDB) work but SqlEngineTests will not, that seems fine for now. We should be able to use the same trick we used for DuckDB here.

Thanks for doing this!

time_granularity=call_parameter_set.time_granularity,
time_granularity=(
call_parameter_set.time_granularity
# TODO: This should be updated once resolution of unspecified grain is supported.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. DAY could be wrong, and then it'll throw a less helpful error, but at least it'll work for daily granularities and error out otherwise.

"sql-client-packages",
]
# Temporary workaround for installing the dbt-duckdb adapter until it's updated to support dbt-core~=1.7.0rc1.
post-install-commands = [
"pip install duckdb>=0.7.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, we need to manually install the adapter dependencies? That's a bummer.

@tlento tlento mentioned this pull request Oct 12, 2023
@plypaul plypaul merged commit d6c5942 into main Oct 13, 2023
22 checks passed
@plypaul plypaul deleted the plypaul--59--update-dsi branch October 13, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants