Remove MarkupSafe dependency #950
Merged
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This stack of pull requests is managed by Graphite. |
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
force-pushed
the
12-19-Remove_MarkupSafe_dependency
branch
from
1a1019c
to
f46c456
Compare
courtneyholcomb
approved these changes
Jan 2, 2024
We do not use MarkupSafe directly. Historically, we've needed this because sometime, somewhere, something was causing runtime problems with the way Pandas was importing and loading MarkupSafe. Whatever that was appears to have been fixed - clean installs still load MarkupSafe (since it's a transitive dependency) and everything appears to be working as normal.
tlento
force-pushed
the
12-19-Remove_MarkupSafe_dependency
branch
from
f46c456
to
9cc3999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #927
We do not use MarkupSafe directly. Historically, we've needed this
because sometime, somewhere, something was causing runtime problems
with the way Pandas was importing and loading MarkupSafe.
Whatever that was appears to have been fixed - clean installs still
load MarkupSafe (since it's a transitive dependency) and everything
appears to be working as normal.