Deprecating state field
#278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @b-per Small change for the deprecation of the |
b-per
reviewed
Jul 19, 2024
| Type: schema.TypeInt, | ||
| Computed: true, | ||
| Description: "PrivatelinkEndpoint state should be 1 = active, as 2 = deleted", | ||
| Deprecated: "Remove this attribute's configuration as it's no longer in use and the attribute will be removed in the next major version of the provider.", |
There was a problem hiding this comment.
This is from a datasource and is computed, so people won't be able to remove its configuration.
I am not too sure about how TF handles deprecation for Computed fields actually.
Do we just update the description for those and mention that the field is going to be deprecated, without the comment that people need to remove its configuration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.